Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal IPN URL Option #514

Closed
angelleye opened this issue Jul 20, 2016 · 1 comment
Closed

PayPal IPN URL Option #514

angelleye opened this issue Jul 20, 2016 · 1 comment
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

In 1.2.x we added an option to enable NOTIFYURL and then specify the URL that you would like to use for IPN.

Since that release I've had quite a few reports of people getting messages from PayPal about sending IPNs to a URL that is not properly receiving them, and in many cases the URL it shows is simply the number 0.

This leads me to believe we've got something wrong with our API request where we're actually sending 0 as the value for NOTIFYURL in cases where the value is empty in WordPress (or disabled).

We need to look into this and make sure that if the option is disabled in the plugin settings it does not get included in the API request at all.

@angelleye
Copy link
Collaborator Author

angelleye commented Aug 6, 2016

@kcppdevelopers For future reference, you're using this...

if( isset($this->notifyurl) && !empty($this->notifyurl)) {

I believe !empty() alone would take care of this. I used to always use...

if( isset($this->notifyurl) && $this->notifyurl != '')) {

I started replacing that with just !empty() and it works as expected. So empty() seems to include whether or not it's set within it already.

Not going to worry about it here, but just wanted to point that out for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant