Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to account for "automatically create username and password" options in WC. #549

Closed
angelleye opened this issue Sep 7, 2016 · 0 comments
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

WooCommerce has the "guest checkout" option that can be enabled or disabled.

In our plugin, if WC guest checkout is disabled (which would require an account for orders) then we tie in that need to login or create an account on the review page we have for Express Checkout after being returned from PayPal.

This would override the option to "skip final review". All of that is working fine.

The issue is that WooCommerce had additional options under the WC -> Settings -> Accounts that we never accounted for...

  • Automatically generate username from customer email
  • Automatically generate customer password.

This is not happening the way our plugin works right now, and users are forced to create their own.

We need to make sure our plugin looks at these settings and acts accordingly. If it's setup to automatically generate the username and password then we could go ahead and do that and skip the review page (if "skip final review" is enabled).

If "skip final review" is not enabled, but these other options to automatically create the un/pw are enabled, then we could still display the review page, but we need to make sure it follows those rules to automatically generate the values so users don't have to the same way WC would on its own in a standard checkout.

@angelleye angelleye added this to the 1.2.5 milestone Sep 7, 2016
@angelleye angelleye modified the milestones: 1.2.5, 1.3.0, 1.3.1 Nov 2, 2016
@kcppdevelopers kcppdevelopers modified the milestones: 1.4.0, 1.3.1 Dec 10, 2016
@kcppdevelopers kcppdevelopers self-assigned this Mar 13, 2017
angelleye pushed a commit that referenced this issue Apr 28, 2017
@angelleye angelleye removed the wontfix label Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant