Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout - No Shipping Bug..?? #571

Closed
angelleye opened this issue Oct 7, 2016 · 2 comments
Closed

Express Checkout - No Shipping Bug..?? #571

angelleye opened this issue Oct 7, 2016 · 2 comments
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

In #174 we added a product level option for "No Shipping Required". When nothing but products where this is enabled are in the cart, then SetExpressCheckout adds NOSHIPPING=1 to the request.

I'm getting reports recently that people are not getting shipping back from PayPal. The first set of logs I looked at show that NOSHIPPING=1 was included in SetExpressCheckout, but they are telling me that they do NOT have the No Shipping Required option enabled for the product.

Seems we may have a bug in that logic somewhere causing the NOSHIPPING parameter to get included it shouldn't be.

Also, it seems to be happening with one of the WooCommerce 2.6.x updates. Not sure if they've made changes to product level settings that affect our No Shipping option..??

@angelleye angelleye added the bug label Oct 7, 2016
@angelleye angelleye added this to the 1.2.5 milestone Oct 7, 2016
@angelleye
Copy link
Collaborator Author

Just talked to this person again, and now he's confirming that he DID have the No Shipping Required option enabled. Once he disabled that, everything worked as expected.

He swears he never enabled that, though, and thinks that something about the WC or WP updates he ran that did it.

Still need to discuss this with the others that have recently reported this. It is odd that I heard from 3 or 4 people at the same time with this same problem.

@angelleye
Copy link
Collaborator Author

Merchant comment:

We have 7 products and they were all set that way. That’s why it was so confusing. Had it been only one product I would’ve looked at that.

Keep in mind that we did do a major upgrade of the site (new theme and data migration) that occurred at the same time as the update to WP ad WC. So that made it more muddy. But I was under the impression that the products tables weren’t touched and were our original data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant