Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC Processing - Options for Adjusting Display of CC Fields #617

Closed
angelleye opened this issue Dec 21, 2016 · 2 comments
Closed

CC Processing - Options for Adjusting Display of CC Fields #617

angelleye opened this issue Dec 21, 2016 · 2 comments
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

Getting requests from some people that they would like to show numbers instead of names for the month, or vice-verse. Also some would like to show 2 digit years and others would like to show 4.

I believe we're using the built in functions for outputting CC forms right now..?? Not sure if it would be worth adding these sorts of options into the settings and then overriding the default WC field options if/when necessary based on options set by the user..??

Something to consider.

@angelleye angelleye added this to the 1.4.0 milestone Dec 21, 2016
@angelleye
Copy link
Collaborator Author

I guess we're not using the WC functions to output form fields like I thought we were..?? Here is some feedback from the user that is requesting this...

Made the following change and it seems to be working ok.

line 400 in wc-gateway-paypal-pro-angeleye.php

        foreach ($months as $num => $name) {
            $form_html .= '<option value=' . $num . '>' . $name . '</option>';
        }

-changed to-

        foreach ($months as $num => $name) {
            $form_html .= '<option value=' . $num . '>' . str_pad($num, 2, '0', STR_PAD_LEFT) . '</option>';
        }

@angelleye
Copy link
Collaborator Author

More feedback from the user:

Another suggestion - credit card number and cvc inputs on the cc form should make use of html5 input types - ie. type="number" , this would help mobile/tablet users as most devices will bring up a contextual keypad for number entry.

I thought we had done this already, but apparently we need to double check all of our gateways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant