Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout - Broken Image URLs #623

Closed
angelleye opened this issue Jan 5, 2017 · 5 comments
Closed

Express Checkout - Broken Image URLs #623

angelleye opened this issue Jan 5, 2017 · 5 comments
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

Seems that not all locale codes have a matching button with PayPal's system, so sometimes we end up with a broken (404) image URL.

For example, the user in the post above has the site set to en_GB, so our code is using https://www.paypalobjects.com/webstatic/en_GB/i/buttons/checkout-logo-medium.png as the button image URL, but that URL results in a 404 not found.

We either need to find a list of supported locale codes for EC buttons, or we need to run some sort of a check to see if a 404 response comes back on the current image. If so, it should fall back to the default image without any locale code specified.

For example, https://www.paypalobjects.com/webstatic/en_GB/i/buttons/checkout-logo-medium.png does not load, but https://www.paypalobjects.com/webstatic/i/buttons/checkout-logo-medium.png loads just fine.

@angelleye angelleye added this to the 1.3.2 milestone Jan 5, 2017
@kcppdevelopers
Copy link
Contributor

PayPal supported below local code:

'da_DK', 'de_DE', 'en_AU', 'en_GB', 'en_US', 'es_ES', 'fr_CA', 'fr_FR','he_IL', 'id_ID', 'it_IT', 'ja_JP', 'nl_NL', 'no_NO', 'pl_PL', 'pt_BR', 'pt_PT', 'ru_RU', 'sv_SE', 'th_TH', 'tr_TR', 'zh_CN', 'zh_HK', 'zh_TW',

I have checked above all the local code with button image URL but only one local code "en_US" is work. like "https://www.paypalobjects.com/webstatic/en_US/i/buttons/checkout-logo-medium.png" URL.

I found another solution for Dynamic Image Integration: https://developer.paypal.com/docs/classic/express-checkout/integration-guide/ECButtonIntegration/

Please let me know your suggestions.

@angelleye
Copy link
Collaborator Author

Looks like that's what we should be using. Go ahead with that please.

@angelleye
Copy link
Collaborator Author

On this current image set, if the background isn't white the text and edges looks very bad...

image

Is there a better image with this method we can use?

@kcppdevelopers
Copy link
Contributor

No, there is only one method to get dynamic Image.

@angelleye
Copy link
Collaborator Author

Ok, then how about we leave the dynamic URLs in place for all local codes besides en_US. If it's en_US (or nothing / default) then we could use the image I had before that looked better on colored backgrounds. Will that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant