Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC Version Compatibility #640

Closed
angelleye opened this issue Feb 24, 2017 · 2 comments
Closed

WC Version Compatibility #640

angelleye opened this issue Feb 24, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

Previously, we had some PHP failures happening when our plugin was enabled if people were on old versions of WC or PHP. As such, we've apparently added some logic that disables all of our gateways if one of those versions is bad.

Some of our gateways work just fine on the older versions, though, so I'd like to figure out exactly which of our gateways require which versions of PHP and WC, and then fine tune the logic so that any gateways compatible on the current server environment will be available, and the rest will be disabled.

Also, if we can, it would be better to still show the gateways in the Checkout settings, but if a gateway is disabled we would add a message notifying them why it's not available.

@angelleye angelleye added this to the 1.4.0 milestone Feb 24, 2017
@angelleye angelleye modified the milestones: 1.4.1, 1.4.0, 1.4.2, 1.4.3 Apr 27, 2017
@angelleye angelleye modified the milestones: 1.4.3, 1.4.4, 1.4.5 May 5, 2017
@angelleye angelleye modified the milestones: 1.4.5, 1.4.6 May 12, 2017
@angelleye angelleye modified the milestones: 1.4.7, 1.4.6 Jun 8, 2017
@angelleye angelleye modified the milestones: 1.4.7, 1.5.0 Aug 2, 2017
@angelleye angelleye modified the milestones: 1.4.7, 1.5.0 Aug 22, 2017
@kcppdevelopers
Copy link
Contributor

@angelleye yes, we've apparently added some logic that disables all of our gateways if Woo version is below 2.6 version. PayPal Rest SDK required 5.3.0 >= PHP version and Braintree SDK required 5.4.0 >= PHP version.

Please let me know your feedback on this.

@angelleye
Copy link
Collaborator Author

@kcppdevelopers Okay, so in this example I don't want to completely hide the REST and Braintree gateways. Instead, I'd like to continue to display them, but show them as disabled with a message that "This gateway requires WooCommerce 2.6 or higher and PHP 5.3 or higher."

Also, it seems that all of the other gateways are getting hidden as well even though they don't have this requirement..?? Any gateways that would be compatible should still be available at all times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant