Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express checkout lets you checkout without a shipping method #677

Closed
shawaj opened this issue May 3, 2017 · 9 comments
Closed

Express checkout lets you checkout without a shipping method #677

shawaj opened this issue May 3, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@shawaj
Copy link

shawaj commented May 3, 2017

The PayPal express checkout allows you to proceed from the cart/checkout page without a shipping method assigned.

This should not be possible

@angelleye angelleye added this to the 1.4.2 milestone May 3, 2017
@angelleye
Copy link
Collaborator

With Express Checkout the shipping / sales tax details would show up on the review page after the user returns back from PayPal. This is because there is no address selected until they log in and pick on (unless they're going through your WC checkout page.)

So the standard procedure with EC is that they are able to skip the checkout page, so they don't have to fill anything in. They log in to PayPal, choose their address, and are sent back to the site where they would then see their shipping / tax options.

Please try that flow and let me know if you still have issues.

@shawaj
Copy link
Author

shawaj commented May 3, 2017 via email

@angelleye
Copy link
Collaborator

Technically, you should be seeing the "no shipping options available" message on the review page. Are you saying the review page is displaying, but simply not showing that and allowing them to continue? Are is your review page not showing up at all (which would mean you must have Skip Final Review enabled in the settings)?

@shawaj
Copy link
Author

shawaj commented May 3, 2017 via email

@angelleye
Copy link
Collaborator

Well, people who don't require shipping often like to skip the final review, so that's why the option is there. If that's not enabled it should be requiring them to choose shipping options on that review page.

We will take a look at why it's letting you get through in the instance you explained, though, and make any necessary adjustments. We'll have to move this to the 1.4.3 update because I can't delay 1.4.2 any longer than it's already been delayed, but we'll get it done ASAP!

@angelleye angelleye modified the milestones: 1.4.3, 1.4.2, 1.4.4 May 5, 2017
@shawaj
Copy link
Author

shawaj commented May 5, 2017

Thanks very much. It's a niche case I guess, in that the product in question should have had a shipping method assigned.

But I think it's better to not let someone check out in this scenario than to let them checkout with no shipping option and have us loose money.

@angelleye
Copy link
Collaborator

Yup, I agree. We'll see what we can do about that.

@shawaj
Copy link
Author

shawaj commented May 5, 2017

Thanks, and thanks for an awesome plugin.

It's great to see someone developing a really great PayPal plugin.... WooCommerce and automattic don't seem capable.

@angelleye
Copy link
Collaborator

Thanks for the feedback! We're in a bit of a rut with this 1.4.x update and all of the changes WC 3.0 made, but we're working it out and then we'll be back to normal again. :)

@angelleye angelleye modified the milestones: 1.4.4, 1.4.5, 1.4.6 May 9, 2017
@angelleye angelleye modified the milestones: 1.4.6, 1.4.5 May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants