Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout - Lots of styling issues being reported. #692

Closed
angelleye opened this issue May 5, 2017 · 7 comments
Closed

Express Checkout - Lots of styling issues being reported. #692

angelleye opened this issue May 5, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

I'm seeing lots of stuff like this after our 1.4.x updates. Previously this would come up sometimes, and I would tell people they need to fix the styling in their theme, which they could usually do just fine. Somehow, though, we had our stuff working well in most themes without the need for adjustment. Something we've done seems to be causing the need for more adjustments in more themes.

It’s OK – I disabled my caching plugin and cleared the cache and the problem has gone.

The only issue I now have is that the PayPal Express checkout button on the product page has moved.

It should underneath the “Add to Basket” button.

Also on one site is has made the custom image tiny and on the other site it has put a purple border round the image.

See here:

http://ibb.co/cuvVJ5

http://ibb.co/mvpCWQ

It’s not a massive problem as I have disabled itnow on the product page, but it would be nice to get a fix.

@angelleye angelleye added the bug label May 5, 2017
@angelleye angelleye added this to the 1.4.3 milestone May 5, 2017
@angelleye
Copy link
Collaborator Author

@kcppdevelopers I wonder if we could add some simple options into settings that would give you the ability to easily add padding/margin/height/width attributes to the PayPal buttons..??

@iMansoorAliKhan
Copy link

I agree to this, and also if we could enhance the interface for our payment gateways that will also be great, and another important thing , just like woocommerce, if we were able to make a basic setup navigator to jumps start the basic setup soon after our plugin is activated.

@angelleye
Copy link
Collaborator Author

angelleye commented May 7, 2017

@MansoorAliKhanOfficial A setup navigator is a good idea, but not something we'll do in 1.4.3. 1.4.3 needs to focus on stability with current features. Then we can improve documentation, setup wizards, etc. in future updates. So if you want to create separate issues for that sort of stuff that is fine, but we need to add them to future milestones.

@kcppdevelopers
Copy link
Contributor

https://www.screencast.com/t/qaeV8t22AUn

I have test with above screenshot themes and applied some CSS changes.

@kcppdevelopers
Copy link
Contributor

@MansoorAliKhanOfficial Can you please test with some other themes and re-generate CSS issue?

@angelleye
Copy link
Collaborator Author

@MansoorAliKhanOfficial Did you get a chance to test this after Jignesh made these last changes?

@kcppdevelopers It looks like you tested with quite a few different themes. I would guess that you're confident things are working smoothly at this point..??

@kcppdevelopers
Copy link
Contributor

@angelleye yes, now I am confident things are working smoothly at this point. I have checked this issue with 26+ developed by woo themes. @MansoorAliKhanOfficial still working on it.

angelleye pushed a commit that referenced this issue May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants