Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout - Billing Address populated when it shouldn't be..?? #793

Closed
angelleye opened this issue Jun 30, 2017 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

while I have left the option 'Set billing address in WooCommerce using the address returned by PayPal" in the plugin config in WC -> Settings -> Paypal Express Checkout UNCHECKED, it still is added as a Billing address

@angelleye angelleye added this to the 1.4.5.1 milestone Jun 30, 2017
@angelleye angelleye modified the milestones: 1.4.6, 1.4.5.1 Jun 30, 2017
@angelleye angelleye modified the milestones: 1.4.6, 1.5.0 Aug 2, 2017
@angelleye angelleye added the bug label Aug 22, 2017
@angelleye angelleye modified the milestones: 1.4.7, 1.5.0, 1.4.6.3 Aug 22, 2017
@kcppdevelopers
Copy link
Contributor

@angelleye I have checked issue and it's working fine for me.

@angelleye
Copy link
Collaborator Author

angelleye commented Sep 7, 2017

@kcppdevelopers I'm not sure how you tested this, but I was indeed able to reproduce the problem the user mentioned.

Just now I ran a test order on woo.angelleye.com using our current dev branch. My settings are configured so that the option to "Set billing address in WooCommerce using the address returned by PayPal" is disabled in the gateway settings.

image

When I checkout, though, I do indeed see the Billing Address populated on the review page as well as on the final order details.

image

Remember, PayPal only returns a name and email address for billing. Then a shipping name and physical address for shipping. So if the option to use the same address for billing is not enabled, we should not be getting the shipping address returned by PayPal filled in for Billing, but we are.

In the example above I changed the shipping address on our review page. So the order wound up with the shipping address returned by PayPal set as the WC billing address when it shouldn't have, and then displays the shipping address I entered on the review page. So again, with this example I should end up with only the name and email address under the Billing info in WC, and then the full shipping name and address I entered on the review page for shipping.

@kcppdevelopers
Copy link
Contributor

kcppdevelopers commented Sep 7, 2017

@angelleye you are right, we need to also follow below WooCommerce setting.

https://www.screencast.com/t/KK4uFevK0dyJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant