Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PayFlow bug in re-trying orders after fraud filter failure..?? #861

Closed
angelleye opened this issue Sep 6, 2017 · 2 comments
Closed

PayFlow bug in re-trying orders after fraud filter failure..?? #861

angelleye opened this issue Sep 6, 2017 · 2 comments
Assignees
@kcppdevelopers
Labels
bug
Milestone
1.4.6.3

Comments

@angelleye
Copy link
Collaborator

angelleye commented Sep 6, 2017 •
edited
Loading

Interesting scenario, and I'm not sure if this is a PayFlow bug or something that's always happened and we've just never seen it, which would be a bit odd.

User reports that when an order is declined due to fraud filter failure (ie. AVS mis-match) and then you re-submit the order with a different address it ends up failing with a duplicate order ID. The first order did not succeed, though, so I'm not sure why PayFlow is not allowing it to be used again.

I'm going to send this to Autumn at PayPal and see what she has to say about it.

Here is a log sample of this happening:

2017-06-07T10:56:37+00:00 INFO PayFlow Request: Array\
(\
    [tender] => C\
    [trxtype] => S\
    [acct] => ****\
    [expdate] => 0519\
    [amt] => 751.04\
    [currency] => USD\
    [dutyamt] => \
    [freightamt] => 102.04\
    [taxamt] => 0\
    [taxexempt] => \
    [custom] => \{"order_id":4753,"order_key":"wc_order_5938304590d40"\}\
    [comment1] => \
    [comment2] => \
    [cvv2] => ****\
    [recurring] => \
    [swipe] => \
    [orderid] => 4753\
    [orderdesc] => Order 4753 on All-Pro Off Road\
    [billtoemail] => ronlamar@gmail.com\
    [billtophonenum] => \
    [billtofirstname] => Ronnie\
    [billtomiddlename] => \
    [billtolastname] => Pettit\
    [billtostreet] => 32 Forestry Ct. Red Garage Building\
    [billtocity] => Clayton\
    [billtostate] => GA\
    [billtozip] => 30525\
    [billtocountry] => US\
    [origid] => \
    [custref] => \
    [custcode] => \
    [custip] => 71.30.14.173\
    [invnum] => 4753\
    [ponum] => \
    [starttime] => \
    [endtime] => \
    [securetoken] => \
    [partialauth] => \
    [authcode] => \
    [merchdescr] => \
    [SHIPTOFIRSTNAME] => Ronnie\
    [SHIPTOLASTNAME] => Pettit\
    [SHIPTOSTREET] => 32 Forestry Ct. Red Garage Building\
    [SHIPTOCITY] => Clayton\
    [SHIPTOSTATE] => GA\
    [SHIPTOCOUNTRY] => US\
    [SHIPTOZIP] => 30525\
    [ITEMAMT] => 649.00\
    [L_NUMBER0] => 2004-APEX-KT\
    [L_NAME0] => FJ Cruiser Apex Rock Sliders\
    [L_COST0] => 649.00\
    [L_QTY0] => 1\
    [L_SKU0] => 2004-APEX-KT\
)\
\
2017-06-07T10:56:42+00:00 INFO PayFlow Endpoint: https://payflowpro.paypal.com\
2017-06-07T10:56:42+00:00 INFO PayFlow Response: Array\
(\
    [RESULT] => 125\
    [PNREF] => BT0PFAA51541\
    [RESPMSG] => Declined by Fraud Service\
    [AUTHCODE] => 111111\
    [AVSADDR] => N\
    [AVSZIP] => Y\
    [CVV2MATCH] => Y\
    [PPREF] => 2PX64405E9064193T\
    [CORRELATIONID] => 4774f71916fe5\
    [PROCAVS] => Z\
    [PROCCVV2] => M\
    [TRANSTIME] => 2017-06-07 09:56:37\
    [BILLTOFIRSTNAME] => Ronnie\
    [BILLTOLASTNAME] => Pettit\
    [AMT] => 751.04\
    [ACCT] => 6132\
    [EXPDATE] => 0519\
    [CARDTYPE] => 0\
    [IAVS] => N\
    [PREFPSMSG] => No Rules Triggered\
    [POSTFPSMSG] => Reject AVS\
    [FPS_POSTXMLDATA] => Array\
        (\
            [373] => <triggeredRules><rule num="1"><ruleId>1</ruleId><ruleID>1</ruleID><ruleAlias>AVS</ruleAlias><ruleDescription>AVS Failure</ruleDescription><action>J</action><triggeredMessage>AVS check failed: Full Security</triggeredMessage><rulevendorparms><ruleParameter num="1"><name>Value</name><value type="String">Full</value></ruleParameter></rulevendorparms></rule></triggeredRules>\
        )\
\
    [RAWREQUEST] => BUTTONSOURCE[24]=AngellEYE_SP_WooCommerce&VERBOSITY[4]=HIGH&USER[10]=*****&VENDOR[10]=*****&PARTNER[6]=PayPal&PWD[8]=*****&TENDER[1]=C&TRXTYPE[1]=S&ACCT[16]=****&EXPDATE[4]=****&AMT[6]=751.04&CURRENCY[3]=USD&FREIGHTAMT[6]=102.04&CUSTOM[54]=\{"order_id":4753,"order_key":"wc_order_5938304590d40"\}&CVV2[3]=****&ORDERID[4]=4753&ORDERDESC[30]=Order 4753 on All-Pro Off Road&BILLTOEMAIL[18]=ronlamar@gmail.com&BILLTOFIRSTNAME[6]=Ronnie&BILLTOLASTNAME[6]=Pettit&BILLTOSTREET[35]=32 Forestry Ct. Red Garage Building&BILLTOCITY[7]=Clayton&BILLTOSTATE[2]=GA&BILLTOZIP[5]=30525&BILLTOCOUNTRY[2]=US&CUSTIP[12]=71.30.14.173&INVNUM[4]=4753&SHIPTOFIRSTNAME[6]=Ronnie&SHIPTOLASTNAME[6]=Pettit&SHIPTOSTREET[35]=32 Forestry Ct. Red Garage Building&SHIPTOCITY[7]=Clayton&SHIPTOSTATE[2]=GA&SHIPTOCOUNTRY[2]=US&SHIPTOZIP[5]=30525&ITEMAMT[6]=649.00&L_NUMBER0[12]=2004-APEX-KT&L_NAME0[28]=FJ Cruiser Apex Rock Sliders&L_COST0[6]=649.00&L_QTY0[1]=1&L_SKU0[12]=2004-APEX-KT\
    [RAWRESPONSE] => RESULT=125&PNREF=BT0PFAA51541&RESPMSG=Declined by Fraud Service&AUTHCODE=111111&AVSADDR=N&AVSZIP=Y&CVV2MATCH=Y&PPREF=2PX64405E9064193T&CORRELATIONID=4774f71916fe5&PROCAVS=Z&PROCCVV2=M&TRANSTIME=2017-06-07 09:56:37&BILLTOFIRSTNAME=Ronnie&BILLTOLASTNAME=Pettit&AMT=751.04&ACCT=6132&EXPDATE=0519&CARDTYPE=0&IAVS=N&PREFPSMSG=No Rules Triggered&POSTFPSMSG=Reject AVS&FPS_POSTXMLDATA[373]=<triggeredRules><rule num="1"><ruleId>1</ruleId><ruleID>1</ruleID><ruleAlias>AVS</ruleAlias><ruleDescription>AVS Failure</ruleDescription><action>J</action><triggeredMessage>AVS check failed: Full Security</triggeredMessage><rulevendorparms><ruleParameter num="1"><name>Value</name><value type="String">Full</value></ruleParameter></rulevendorparms></rule></triggeredRules>\
)\
\
2017-06-07T11:08:08+00:00 INFO PayFlow Request: Array\
(\
    [tender] => C\
    [trxtype] => S\
    [acct] => ****\
    [expdate] => 0519\
    [amt] => 751.04\
    [currency] => USD\
    [dutyamt] => \
    [freightamt] => 102.04\
    [taxamt] => 0\
    [taxexempt] => \
    [custom] => \{"order_id":4753,"order_key":"wc_order_5938304590d40"\}\
    [comment1] => \
    [comment2] => \
    [cvv2] => ****\
    [recurring] => \
    [swipe] => \
    [orderid] => 4753\
    [orderdesc] => Order 4753 on All-Pro Off Road\
    [billtoemail] => ronlamar@gmail.com\
    [billtophonenum] => \
    [billtofirstname] => Ronnie\
    [billtomiddlename] => \
    [billtolastname] => Pettit\
    [billtostreet] => 236 File St. \
    [billtocity] => Clayton\
    [billtostate] => GA\
    [billtozip] => 30525\
    [billtocountry] => US\
    [origid] => \
    [custref] => \
    [custcode] => \
    [custip] => 71.30.14.173\
    [invnum] => 4753\
    [ponum] => \
    [starttime] => \
    [endtime] => \
    [securetoken] => \
    [partialauth] => \
    [authcode] => \
    [merchdescr] => \
    [SHIPTOFIRSTNAME] => Ronnie\
    [SHIPTOLASTNAME] => Pettit\
    [SHIPTOSTREET] => 32 Forestry Ct. Red Garage Building\
    [SHIPTOCITY] => Clayton\
    [SHIPTOSTATE] => GA\
    [SHIPTOCOUNTRY] => US\
    [SHIPTOZIP] => 30525\
    [ITEMAMT] => 649.00\
    [L_NUMBER0] => 2004-APEX-KT\
    [L_NAME0] => FJ Cruiser Apex Rock Sliders\
    [L_COST0] => 649.00\
    [L_QTY0] => 1\
    [L_SKU0] => 2004-APEX-KT\
)\
\
2017-06-07T11:08:11+00:00 INFO PayFlow Endpoint: https://payflowpro.paypal.com\
2017-06-07T11:08:11+00:00 INFO PayFlow Response: Array\
(\
    [RESULT] => 30\
    [PNREF] => BP0PE763E6BD\
    [RESPMSG] => Duplicate trans: 10536-The transaction was refused as a result of a duplicate invoice ID supplied.  Attempt with a new invoice ID\
    [HOSTCODE] => 10536\
    [TRANSTIME] => 2017-06-07 10:08:08\
    [BILLTOFIRSTNAME] => Ronnie\
    [BILLTOLASTNAME] => Pettit\
    [AMT] => 751.04\
    [ACCT] => 6132\
    [EXPDATE] => 0519\
    [CARDTYPE] => 0\
    [PREFPSMSG] => No Rules Triggered\
    [RAWREQUEST] => BUTTONSOURCE[24]=AngellEYE_SP_WooCommerce&VERBOSITY[4]=HIGH&USER[10]=*****&VENDOR[10]=*****&PARTNER[6]=PayPal&PWD[8]=*****&TENDER[1]=C&TRXTYPE[1]=S&ACCT[16]=****&EXPDATE[4]=****&AMT[6]=751.04&CURRENCY[3]=USD&FREIGHTAMT[6]=102.04&CUSTOM[54]=\{"order_id":4753,"order_key":"wc_order_5938304590d40"\}&CVV2[3]=****&ORDERID[4]=4753&ORDERDESC[30]=Order 4753 on All-Pro Off Road&BILLTOEMAIL[18]=ronlamar@gmail.com&BILLTOFIRSTNAME[6]=Ronnie&BILLTOLASTNAME[6]=Pettit&BILLTOSTREET[13]=236 File St. &BILLTOCITY[7]=Clayton&BILLTOSTATE[2]=GA&BILLTOZIP[5]=30525&BILLTOCOUNTRY[2]=US&CUSTIP[12]=71.30.14.173&INVNUM[4]=4753&SHIPTOFIRSTNAME[6]=Ronnie&SHIPTOLASTNAME[6]=Pettit&SHIPTOSTREET[35]=32 Forestry Ct. Red Garage Building&SHIPTOCITY[7]=Clayton&SHIPTOSTATE[2]=GA&SHIPTOCOUNTRY[2]=US&SHIPTOZIP[5]=30525&ITEMAMT[6]=649.00&L_NUMBER0[12]=2004-APEX-KT&L_NAME0[28]=FJ Cruiser Apex Rock Sliders&L_COST0[6]=649.00&L_QTY0[1]=1&L_SKU0[12]=2004-APEX-KT\
    [RAWRESPONSE] => RESULT=30&PNREF=BP0PE763E6BD&RESPMSG=Duplicate trans: 10536-The transaction was refused as a result of a duplicate invoice ID supplied.  Attempt with a new invoice ID&HOSTCODE=10536&TRANSTIME=2017-06-07 10:08:08&BILLTOFIRSTNAME=Ronnie&BILLTOLASTNAME=Pettit&AMT=751.04&ACCT=6132&EXPDATE=0519&CARDTYPE=0&PREFPSMSG=No Rules Triggered\
)\
@angelleye angelleye added the bug label Sep 6, 2017
@angelleye angelleye modified the milestones: 1.5.0, 1.4.6.3 Sep 6, 2017
kcppdevelopers added a commit that referenced this issue Sep 12, 2017
@kcppdevelopers
PayFlow bug in re-trying orders after fraud filter failure, ref #861
09d85ab
@kcppdevelopers kcppdevelopers self-assigned this Sep 12, 2017
@angelleye
Copy link
Collaborator Author

@kcppdevelopers Can you please elaborate on what was done here for me? It looks like there's quite a bit of code changes here..??

@kcppdevelopers
Copy link
Contributor

kcppdevelopers commented Sep 12, 2017 •
edited
Loading

@angelleye I have reviewed code and found lot code are not readable format, I just make it readable and resolved above issue.

angelleye pushed a commit that referenced this issue Sep 15, 2017
Updates changelog, ref #861
71478b2
@angelleye angelleye mentioned this issue Sep 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcppdevelopers kcppdevelopers

Labels
bug
Projects
None yet
Milestone
1.4.6.3
Development

No branches or pull requests
1 participant
@kcppdevelopers