Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Logos #901

Closed
angelleye opened this issue Oct 13, 2017 · 8 comments
Closed

Settings Logos #901

angelleye opened this issue Oct 13, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

In our Settings -> PayPal for Woo I want to add logos for each of the PayPal products instead of text headers.

@angelleye angelleye added this to the 1.4.7 milestone Oct 13, 2017
@angelleye
Copy link
Collaborator Author

angelleye commented Oct 13, 2017

I would also like to make each separate product a tile on the page, instead of stacked text. So basically divs floated left so they're side by side with a logo at the top of each, basic description, link to settings, etc.

@angelleye angelleye modified the milestones: 1.4.7, 1.4.6.6 Oct 16, 2017
@angelleye angelleye self-assigned this Oct 16, 2017
@kcppdevelopers
Copy link
Contributor

@angelleye I think we need to new tab for Premium Extensions / Support same like PayPal IPN for WooCoomerce.

@angelleye
Copy link
Collaborator Author

@kcppdevelopers Yes, I agree. I think I have a separate issue for that, actually, but we can do that here.

We'll need to pull products using a specific tag the same way we do in the IPN plugin. In this case the tag will be paypal_woocommerce_premium_extension

@angelleye
Copy link
Collaborator Author

@kcppdevelopers Something isn't right here. The new premium extensions stuff is showing up where the payment gateways should be showing up, and the same image is being output for every product.

image

@angelleye
Copy link
Collaborator Author

@kcppdevelopers Ah, nevermind, I guess this is just setup as tiles now, but you didn't use the separate logos..??

We should see a PayPal Express Checkout logo in that tile, and a PayPal PayFlow logo in that tile, etc. We should be able to find good quality graphics for that using Google image searches.

@angelleye
Copy link
Collaborator Author

The premium extensions tab isn't displaying any products. I thought I had something setup with the tag we're using here, but I'll double check.

@angelleye
Copy link
Collaborator Author

@kcppdevelopers Please use the attached logos for the gateway tab.
paypal-for-woo-gateway-logos.zip

@angelleye
Copy link
Collaborator Author

angelleye commented Nov 10, 2017

@kcppdevelopers We need to add a little bit of spacing here:

image

The line about "Premium extension available at www.angelleye.com" needs to be spaced a little better so it's not smashed up against the tabs. Also, it should be aligned left even with the tabs. Right now it's not aligned and it just doesn't look clean.

kcppdevelopers added a commit that referenced this issue Nov 10, 2017
kcppdevelopers added a commit that referenced this issue Nov 10, 2017
kcppdevelopers added a commit that referenced this issue Nov 10, 2017
kcppdevelopers added a commit that referenced this issue Nov 10, 2017
angelleye pushed a commit that referenced this issue Nov 10, 2017
angelleye pushed a commit that referenced this issue Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant