Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout User Not Created When Name, SurName and Email are not empty #974

Closed
dtugend opened this issue Dec 30, 2017 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@dtugend
Copy link

dtugend commented Dec 30, 2017

This bug was introduced in
ee9d8a6

The bug is in in line 1337 in express-checkout/class-wc-gateway-paypal-express-request-angelleye.php:
https://github.com/angelleye/paypal-woocommerce/blob/release/angelleye-includes/express-checkout/class-wc-gateway-paypal-express-request-angelleye.php#L1337

if( empty($first_name) || empty($last_name) || empty($email)) {

If all conditions are met, no user is created.

This should probably be

if(!empty($email)) {
@angelleye angelleye added the bug label Dec 30, 2017
@angelleye angelleye added this to the 1.4.7.1 milestone Dec 30, 2017
@angelleye
Copy link
Collaborator

@ripieces Thanks, we'll take a look and make necessary adjustments in a patch update.

@kcppdevelopers Please review and adjust accordingly.

@angelleye
Copy link
Collaborator

@ripieces We'll be releasing a 1.4.7.1 update shortly that resolves this issue. Thanks again for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants