Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paypal_transaction post type arguments #1031

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

diedexx
Copy link
Contributor

@diedexx diedexx commented Mar 22, 2018

The paypal_transaction post type is being registered with a lot of arguments. Arguments which aren't necessary because their default values are the same, or their default or other values fit the post type better.

I've changed the following

argument old value new value reason
show_ui false false (default) default value is the same
capability_type 'post' 'post' (default) default value is the same
capabilities array( 'create_posts' => false) array() (default) Its value doesn't seem to matter in the case of paypal_transactions. Just leave it as its default value
map_meta_cap true null (default) which translates to true default value is the same
publicly_queryable true false (default) Transactions should not be publicly accessible
exclude_from_search false false (default) default value is the same
hierarchical false false (default) default value is the same
rewrite array('slug' => 'paypal_ip') true (default) Its value doesn't seem to matter in the case of paypal_transactions. Just leave it as its default value
query_var true false Transactions should not be publicly accessible
supports array('', '') array() (default) which translates to ( 'title', 'editor' ) Its value doesn't seem to matter in the case of paypal_transactions. Just leave it as its default value
has_archive true false (default) Transactions should not be publicly accessible, and thus shouldn't have an archive
show_in_nav_menus FALSE false (default) default value is the same

@angelleye angelleye added this to the 1.4.9 milestone Mar 22, 2018
@angelleye
Copy link
Collaborator

@diedexx thanks for the feedback and the commit! We'll review and include in our 1.4.9 update coming soon. Thanks!

@angelleye angelleye modified the milestones: 1.4.9, 1.4.8.1 Mar 23, 2018
@kcppdevelopers kcppdevelopers merged commit 9c3bd6a into angelleye:dev Mar 23, 2018
angelleye pushed a commit that referenced this pull request Mar 23, 2018
@diedexx diedexx deleted the private-transaction-posttype branch March 23, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants