Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express Checkout - Checkout Page Display : 532 #1395

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Express Checkout - Checkout Page Display : 532 #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e4cfe
Express Checkout - Checkout Page Display, PFW-532
kcppdevelopers Nov 25, 2019
c103d23
Express Checkout - Checkout Page Display, PFW-532
kcppdevelopers Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion angelleye-includes/express-checkout/class-wc-gateway-paypal-express-helper-angelleye.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function __construct() {
$this->pp_button_type_my_custom = !empty($this->setting['pp_button_type_my_custom']) ? $this->setting['pp_button_type_my_custom'] : WC_Gateway_PayPal_Express_AngellEYE::angelleye_get_paypalimage();
$this->show_on_product_page = !empty($this->setting['show_on_product_page']) ? $this->setting['show_on_product_page'] : 'no';
$this->review_title_page = !empty($this->setting['review_title_page']) ? $this->setting['review_title_page'] : 'Review Order';
$this->show_on_checkout = !empty($this->setting['show_on_checkout']) ? $this->setting['show_on_checkout'] : 'top';
$this->show_on_checkout = !empty($this->setting['show_on_checkout']) ? $this->setting['show_on_checkout'] : 'both';
$this->button_position = !empty($this->setting['button_position']) ? $this->setting['button_position'] : 'bottom';
$this->show_on_cart = !empty($this->setting['show_on_cart']) ? $this->setting['show_on_cart'] : 'yes';
$this->show_on_minicart = !empty($this->setting['show_on_minicart']) ? $this->setting['show_on_minicart'] : 'no';
Expand Down
4 changes: 2 additions & 2 deletions classes/wc-gateway-paypal-express-angelleye.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function __construct() {
$this->save_abandoned_checkout = 'yes' === $this->get_option('save_abandoned_checkout', 'no');
self::$log_enabled = $this->debug;
$this->error_email_notify = 'yes' === $this->get_option('error_email_notify', 'no');
$this->show_on_checkout = $this->get_option('show_on_checkout', 'top');
$this->show_on_checkout = $this->get_option('show_on_checkout', 'both');
$this->paypal_account_optional = $this->get_option('paypal_account_optional', 'no');
$this->error_display_type = $this->get_option('error_display_type', 'detailed');
$this->landing_page = $this->get_option('landing_page', 'login');
Expand Down Expand Up @@ -1105,7 +1105,7 @@ public function init_form_fields() {
'top' => __('Display at the top of the checkout page.', 'paypal-for-woocommerce'),
'regular' => __('Display in general list of enabled gateways on checkout page.', 'paypal-for-woocommerce'),
'both' => __('Display both at the top and in the general list of gateways on the checkout page.')),
'default' => 'top',
'default' => 'both',
'class' => 'wc-enhanced-select',
'description' => __('Displaying the checkout button at the top of the checkout page will allow users to skip filling out the forms and can potentially increase conversion rates.'),
'desc_tip' => true,
Expand Down