-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialSuccess Error Handling, PFW-636 #1458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comment and resolve the issue, so that we can test it.
@@ -92,4 +92,10 @@ public function ec_is_response_successwithwarning($paypal_response) { | |||
return true; | |||
} | |||
} | |||
|
|||
public function ec_is_response_partialsuccess($paypal_response) { | |||
if (!empty($paypal_response['ACK']) && strtoupper($paypal_response['ACK']) == 'PartialSuccess') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcppdevelopers I think this condition will never turn to true, because you ae comparing a upper case string with a different string. either convert PartialSuccess as full string. or make sure convert everything into small case and partialsuccess as well to compare properly.
No description provided.