Auto cancellation & refund based on transaction Seller Protection response #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed on gateway's seller-protection settings
…tion result for PayPal Express
|
Cool, thanks again for the contributions! We'll review this and most likely get it merged in the 1.2 update. |
|
@kcppdevelopers Please review this and merge into the dev branch if everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is to allow the merchant to automatically decline transactions that either have no seller protection or partial protection (partial protection would be for "item not received" PayPal cases, per:
ProtectionEligibilityresponse field from https://developer.paypal.com/docs/classic/api/merchant/DoExpressCheckoutPayment_API_Operation_SOAP/#paymentinfotype-fields and https://developer.paypal.com/docs/classic/api/merchant/GetTransactionDetails_API_Operation_NVP/ ).The setting is exposed to the gateway's settings page, where the merchant is able to select what kind of protection they would like to enforce (e.g. if they are using woocommerce to ship out tangible goods or perhaps).
It seems I was a little behind on the current protocol, since 64.4 we should use
ProtectionEligibilityTypeinstead ofProtectionEligibility(which makes sense, the responses easier to read plain-english). If you guys think that this can be used, I can update the response checks with another pull request. For now, it seems PayPal will not be deprecating theProtectionEligibilityfield that I am currently using since it still might be widely used...and it serves the same purpose asProtectionEligibilityType.I also manually added the translation strings to "paypal-for-woocommerce.pot" for consistency, but I am sure one of you here can generate them on the fly.