Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location implementation #8

Open
angelodlfrtr opened this issue Jan 11, 2024 · 2 comments
Open

Location implementation #8

angelodlfrtr opened this issue Jan 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@angelodlfrtr
Copy link
Owner

Support to geo primitives like geo#Point could be added, maybe under a feature.

@angelodlfrtr angelodlfrtr added the enhancement New feature or request label Jan 11, 2024
@thulasizwe-ntamane
Copy link

Hi guys,

Firstly, great work on this API - it's simple to use and intuitive.

I noticed that the module crashes when geolocation fails, perhaps from garbage data or the geolocation cannot return coordinates.

I have applied a fix in an offline branch created from the main branch and would like to contribute these changes.

@angelodlfrtr
Copy link
Owner Author

Hi @thulasizwe-ntamane, great, do not hesitate to create a pull request !

You can watch for github doc about creating pull request : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants