Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if calculate_dist_matrix or compute_closenum functions can be simplified #130

Closed
ngreenwald opened this issue Jul 20, 2020 · 1 comment
Closed

Investigate if calculate_dist_matrix or compute_closenum functions can be simplified #130

ngreenwald opened this issue Jul 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ngreenwald
Copy link
Member

Both of these functions in their current implementation have assumptions about the location/ordering of each cell label in the matrix that they produce which is causing problems/requiring use to code around them.

It would be good to investigate if there are simpler ways to perform these same tasks that don't require so much acrobatics in other areas of the codebase.
@ngreenwald ngreenwald added the enhancement New feature or request label Aug 5, 2020
@ngreenwald ngreenwald mentioned this issue Aug 13, 2020
Closed
@ackagel ackagel mentioned this issue Aug 13, 2020
Merged
@ngreenwald
Copy link
Member Author

Closed by #163 and #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngreenwald