Handle exception in BuildsEndpoint

Check whether `filters` variable is defined. Fixes buildbot#4903
angeloudy · Jul 22, 2019 · 6b775d7 · 6b775d7
1 parent 3a084f7
commit 6b775d7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/master/buildbot/data/builds.py b/master/buildbot/data/builds.py
@@ -170,12 +170,15 @@ def get(self, resultSpec, kwargs):
         for b in builds:
             data = yield self.db2data(b)
             # Avoid to request DB for Build's properties if not specified
-            if filters:  # pragma: no cover
-                props = yield self.master.db.builds.getBuildProperties(b['id'])
-                filtered_properties = self._generate_filtered_properties(
-                    props, filters)
-                if filtered_properties:
-                    data['properties'] = filtered_properties
+            try:
+                if filters:  # pragma: no cover
+                    props = yield self.master.db.builds.getBuildProperties(b['id'])
+                    filtered_properties = self._generate_filtered_properties(
+                        props, filters)
+                    if filtered_properties:
+                        data['properties'] = filtered_properties
+            except NameError:
+                pass
             buildscol.append(data)
         return buildscol