Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to hide 0 references #1

Closed
vogella opened this issue Mar 22, 2018 · 9 comments
Closed

Allow to hide 0 references #1

vogella opened this issue Mar 22, 2018 · 9 comments

Comments

@vogella
Copy link
Contributor

vogella commented Mar 22, 2018

I think it would be nice to allow to hide 0 reference. I think it would also make a good default to only show the reference is there is one.

selection_250

@angelozerr
Copy link
Owner

angelozerr commented Mar 22, 2018

Indeed it should be very cool if we could customize that, but today CodeMining API doesn't support this feature:

don't draw the line header annotation according the result of resolved mining (in this case "0 reference").

It's a very interesting usecase, I will see if it's easy to implement it.

Thanks for your very cool idea!

@angelozerr
Copy link
Owner

@vogella to fix this issue easily, I need https://git.eclipse.org/r/#/c/120005/

@angelozerr
Copy link
Owner

By waiting accept of https://git.eclipse.org/r/#/c/120005/ have you an idea about UI Preferences?

An idea is to have this UI

[x] Show references [x] only when there are several references

An idea are welcome!

@vogella
Copy link
Contributor Author

vogella commented Mar 22, 2018 via email

@vogella
Copy link
Contributor Author

vogella commented Mar 22, 2018 via email

angelozerr added a commit that referenced this issue Mar 22, 2018
@angelozerr
Copy link
Owner

@vogella here the UI result:

image

If you click on =Only if there is at least one reference, you will see no command`. Once https://git.eclipse.org/r/#/c/120005/ will be accepted it should work.

@angelozerr
Copy link
Owner

@vogella can I close this issue?

@vogella
Copy link
Contributor Author

vogella commented Apr 15, 2018 via email

@angelozerr
Copy link
Owner

Thanks @vogella for your feedback. I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants