New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace material-dialogs with AppCompat AlertDialog #32
Replace material-dialogs with AppCompat AlertDialog #32
Conversation
Great work! 👍
|
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
The API 19 emulator was prohibitively slow on my machine so I could not manage to install the sample on it, and on API 21 the app crashed on launch immediately: Stacktrace
I've attached the screenshot for API 29. |
It does fix the crash, but I can't attach a screenshot for it since storage access is automatically granted on API 21 so the code path for the dialogs is never hit. |
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This PR removes the material-dialogs dependency in the library by switching its uses to the AppCompat AlertDialog.
This has multiple benefits:
Fixes #33
Screenshots
API 29: