Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set build flags differently for release builds #159

Open
rhelmot opened this issue Sep 26, 2018 · 9 comments
Open

Set build flags differently for release builds #159

rhelmot opened this issue Sep 26, 2018 · 9 comments
Assignees

Comments

@rhelmot
Copy link
Member

rhelmot commented Sep 26, 2018

Right now all builds are -g -O2, which seems bad. We should probably have some good way to detect the build profile and switch between -g -O0 (maybe -g -O1?) and -Ofast or whatever other flags we want for release.

@ltfish
Copy link
Member

ltfish commented Sep 26, 2018

+1

@zardus
Copy link
Member

zardus commented Sep 26, 2018

Are we sure we need this? The only people that will likely be diving through pyvex code is us anyways, and we can make ad hoc changes to the flags in that scenario. Otherwise, I don't see why we ever want anything but -Ofast...

@rhelmot
Copy link
Member Author

rhelmot commented Sep 26, 2018

Of course not, but I'd like my life to be a little easier...

@zardus
Copy link
Member

zardus commented Sep 26, 2018

If you think you'll save more time building in build profile detection than changing the compiler flags when needed, then it makes sense of course. I'm not so sure that it'll amortize, though.

@rhelmot
Copy link
Member Author

rhelmot commented Sep 26, 2018

if I cared about amortizing profits instead of doing the right thing at all times I would be living my life very very very differently...

@zardus
Copy link
Member

zardus commented Sep 26, 2018

Hahahaha, fair point :-)

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has no recent activity. Please comment or add the pinned tag to prevent this issue from being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants