fix for removing preconstraints which were also constraints added during tracing #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salls
force-pushed
the
fix/driller_invalid_inputs
branch
from
c85ae0e
to
0b8f64d
Compare
ltfish
reviewed
Mar 10, 2017
tracer/tracer.py
Outdated
| @@ -588,7 +587,12 @@ def remove_preconstraints(self, path, to_composite_solver=True, simplify=True): | |||
| for con in self.preconstraints: | |||
| precon_cache_keys.add(con.cache_key) | |||
|
|
|||
| new_constraints = filter(lambda x: x.cache_key not in precon_cache_keys, path.state.se.constraints) | |||
| # if we used the repacement solver we didn't add constraints we need to remove so keep all constraints | |||
There was a problem hiding this comment.
Oh I see I'm missing an "L"
There was a problem hiding this comment.
:D
pylint should also do a spelling check for us!
salls
force-pushed
the
fix/driller_invalid_inputs
branch
from
0b8f64d
to
bd80b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.