Fixed issue with ifconfig.co #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thanks for this! How about replacing ifconfig entirely by the |
|
I would not replace it entirely, it can also fail in some circumstances, let's use it as a fallback. |
angristan
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I am using this script on some VMs in Azure. It worked quite well for a while but stopped working yesterday. The issue is that when obtaining the public IP address, the
https://ifconfig.cois now behind the Cloudfare, so the CURL request to it fails with HTTP code 503 and in response is this HTML instead of an IP address:This PR comes with a fallback, whenever the
https://ifconfig.cowill not be useable for any reason, it will utilize the Google DNS service for those purposes.I have tested it on Azure VMs and locally and it is working just fine.