Add Copy Command to clipboard #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrykoala
requested changes
Oct 14, 2021
There was a problem hiding this comment.
Great Job @amimaro, Everything works as expected. Only a small change requested on naming 👍
src/app/components/suite/suite.vue
Outdated
| @@ -5,7 +5,7 @@ | |||
| <task-card | |||
| :key="index" :task="task" :index="index" :open="selectedTask===index" | |||
| @selected="selectTask(index)" @save="saveTask(index, $event)" @delete="deleteTask(index)" | |||
| @duplicate="duplicateTask(index)" | |||
| @duplicate="duplicateTask(index)" @copy-command="copyCommandTask(index)" | |||
There was a problem hiding this comment.
I think copyCommandTask may be a bit confusing. copyTaskCommand seems like a slightly better wording for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
If I got the right idea. o/
Was create a new menu option "Copy Command" on right click at the task.
The event copies the task command using clipboard from electron.
Currently there is one test failing at task.test.js it("Stop task").
Please, let me know if it must have some changes.
Appreciate any feedback.
Issue: Copy command option in context menu #428
Please, before doing the PR make sure that you are following the intructions described in CONTRIBUTING.md and you have completed the following checklist
Checklist
devbranchdevnpm run test)Thanks for contributing to Gaucho