Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitFor is deprecated #468

Closed
angrykoala opened this issue Oct 24, 2020 · 2 comments
Closed

waitFor is deprecated #468

angrykoala opened this issue Oct 24, 2020 · 2 comments
Labels
bug Non-critical bug

Comments

@angrykoala
Copy link
Owner

Puppeteer waitfor method is deprecated, 2 possible solutions:

  • Change Wendigo's waitFor to support new Puppeteer methods
  • Deprecate waitfor in favor of Puppeteer approach
@angrykoala angrykoala added the bug Non-critical bug label Jan 13, 2021
@angrykoala
Copy link
Owner Author

To avoid compatibility issues, the same method waitFor will be kept for wendigo 3.0 (with the same behavior). this method, under the hood will call the specific methods from Puppeteer instead of the deprecated waitFor:

  • waitForXPath
  • waitForSelector
  • waitForFunction

This is to keep wendigo API simple, but future methods (waitForSelector and waitForFunction) could be added if deemed necessary.

The main limitation of this approach is that waitForFunction cannot be called with a string (it would be detected as a selector instead). This can still be done by accessing puppeteer page directly: browser.page.waitForFunction

@angrykoala
Copy link
Owner Author

This change will be available in wendigo 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Non-critical bug
Projects
None yet
Development

No branches or pull requests

1 participant