Supression #20
Merged
Supression #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angrymeir when you will have some time can you take a look at this change ? :) |
|
@angrymeir Will you find a time this week to look at this change? |
angrymeir
requested changes
Sep 22, 2022
|
|
||
| def test_get_config_no_file(self): | ||
| # given: | ||
| input_config_path = "resources/test_config/test_get_config_no_file/ss2ju-config.yml" |
There was a problem hiding this comment.
- The actual path here is
resources/test_config/test_get_config_empty_file/ss2ju-config.yml:)
There was a problem hiding this comment.
I have added empty test_get_config_no_file dir, and this test is checking if when file does not exist, the program should return empty config
tests/test_config.py
Outdated
|
|
||
| # then: | ||
| expected = Config([Suppression('cwe', '2555'), Suppression('find_sec_bugs_type', 'SPRING_ENDPOINT')]) | ||
| assert expected == config |
There was a problem hiding this comment.
I guess this assert statement is redundant, as assertEqual is based on "==" (see here). Or am I missing something?
There was a problem hiding this comment.
Yes, you are rigth :)
marwin1991
commented
Sep 24, 2022
| from junit_xml import TestSuite, TestCase | ||
|
|
||
| # is it correct import changed from .parser ? I've get error ImportError: attempted relative import with no known parent package | ||
| from secscanner2junit.config import Config |
There was a problem hiding this comment.
@angrymeir is it corrent import?
|
@angrymeir :) |
angrymeir
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.