Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Enable route guards #49

Closed
meeroslav opened this issue Aug 19, 2020 · 0 comments
Closed

[Feat] Enable route guards #49

meeroslav opened this issue Aug 19, 2020 · 0 comments
Assignees

Comments

@meeroslav
Copy link
Collaborator

Route unregister should be called upon route destroy. Unregistering route will remove it from the routes$ and trigger navigation. This is precondition to having route guards using structural directives.

The intended behaviour is different to @angular/router canActivate:

Guard true false
@angular/router navigate to route stop navigation
angular-routing navigate to route navigate to fallback route
@meeroslav meeroslav changed the title [Feat] Add route unregister [Feat] Add route guards Nov 2, 2020
@meeroslav meeroslav changed the title [Feat] Add route guards [Feat] Enable route guards Nov 2, 2020
meeroslav added a commit to meeroslav/angular-routing that referenced this issue Nov 2, 2020
meeroslav added a commit to meeroslav/angular-routing that referenced this issue Nov 2, 2020
@brandonroberts brandonroberts added this to To do in 0.3.0 release Nov 6, 2020
@meeroslav meeroslav self-assigned this Nov 10, 2020
0.3.0 release automation moved this from To do to Done Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant