Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add ng add support #9

Closed
brandonroberts opened this issue Jul 10, 2020 · 4 comments · Fixed by #16
Closed

[Feat] Add ng add support #9

brandonroberts opened this issue Jul 10, 2020 · 4 comments · Fixed by #16

Comments

@brandonroberts
Copy link
Collaborator

  • Updates the package.json
  • Adds RoutingModule.forRoot() to the AppModule
@santoshyadavdev
Copy link
Contributor

I will take it Brandon.

@santoshyadavdev
Copy link
Contributor

@brandonroberts is folder structure looks fine to you, Sorry for asking, actually I know plugins create a separate lib for schematics and builder, but here we are creating schematics as part of the library, which I have not done as part of Nx so a little bit confused here.

@brandonroberts
Copy link
Collaborator Author

Yea, we'll have to compile the schematics separately, and probably use the @schematics/angular package or another utility library to add the imports for RoutingModule.forRoot() to an NgModule.

@santoshyadavdev
Copy link
Contributor

Cool, thanks 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants