Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for widget title being overwritten #139

Merged
merged 2 commits into from Sep 9, 2015

Conversation

fuzzypete
Copy link
Contributor

Fix for widget title being overwritten.. Tried to avoid reindentation issues, but i might have failed... this is my first pull request ever... sorry if i hoarked something

@sdorra sdorra added the bug label Sep 9, 2015
@sdorra sdorra self-assigned this Sep 9, 2015
sdorra added a commit that referenced this pull request Sep 9, 2015
Fix for widget title being overwritten
@sdorra sdorra merged commit ca50c77 into angular-dashboard-framework:master Sep 9, 2015
@sdorra
Copy link
Member

sdorra commented Sep 9, 2015

Thanks. Next time please do not commit the dist folder. The dist folder is only generated for releases.

@fuzzypete
Copy link
Contributor Author

Ah, right.. Sorry about that. I didn't do that, originally, but i wanted
to reference it my project which is using bower. When i tried to reference
my forked repo with the #master commit id, it still pulled the 0.10.0
release.. I didn't know a best practice to do what i wanted and pushed the
dist to my github repo to make it work... didn't think about the upstream
implications, though.
On Sep 9, 2015 9:26 AM, "Sebastian Sdorra" notifications@github.com wrote:

Thanks. Next time please do not commit the dist folder. The dist folder is
only generated for releases.


Reply to this email directly or view it on GitHub
#139 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants