feat!: update to Angular v18, drop Angular v17

angular-eslint · May 22, 2024 · 209f10f · 209f10f
1 parent 4efe5e9
commit 209f10f
Show file tree

Hide file tree

Showing 4 changed files with 221 additions and 304 deletions.
diff --git a/package.json b/package.json
@@ -52,8 +52,8 @@
   "devDependencies": {
     "@actions/core": "1.10.1",
     "@actions/github": "6.0.0",
-    "@angular/cli": "17.3.6",
-    "@angular/compiler": "17.3.9",
+    "@angular/cli": "18.0.0-rc.3",
+    "@angular/compiler": "18.0.0-rc.3",
     "@commitlint/cli": "19.3.0",
     "@commitlint/config-conventional": "19.2.2",
     "@nx/devkit": "19.0.5",
@@ -66,7 +66,7 @@
     "@rollup/plugin-commonjs": "^25.0.0",
     "@rollup/plugin-node-resolve": "^15.0.2",
     "@rollup/plugin-typescript": "^11.1.0",
-    "@schematics/angular": "17.3.6",
+    "@schematics/angular": "18.0.0-rc.3",
     "@swc-node/register": "1.9.1",
     "@swc/cli": "0.3.12",
     "@swc/core": "1.5.7",

diff --git a/packages/schematics/package.json b/packages/schematics/package.json
@@ -48,7 +48,7 @@
     "eslint": "8.57.0"
   },
   "peerDependencies": {
-    "@angular/cli": ">= 17.0.0 < 18.0.0"
+    "@angular/cli": ">= 18.0.0 < 19.0.0 || ^18.0.0-rc.3"
   },
   "gitHead": "e2006e5e9c99e5a943d1a999e0efa5247d29ec24"
 }
diff --git a/packages/template-parser/tests/index.test.ts b/packages/template-parser/tests/index.test.ts
@@ -10722,8 +10722,8 @@ describe('parseForESLint()', () => {
                   },
                 },
               ],
-              "contextVariables": Object {
-                "$count": Variable {
+              "contextVariables": Array [
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -10772,7 +10772,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$count",
+                  "name": "$index",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -10821,10 +10821,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$count",
+                  "value": "$index",
                   "valueSpan": undefined,
                 },
-                "$even": Variable {
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -10873,7 +10873,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$even",
+                  "name": "$first",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -10922,10 +10922,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$even",
+                  "value": "$first",
                   "valueSpan": undefined,
                 },
-                "$first": Variable {
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -10974,7 +10974,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$first",
+                  "name": "$last",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11023,10 +11023,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$first",
+                  "value": "$last",
                   "valueSpan": undefined,
                 },
-                "$index": Variable {
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11075,7 +11075,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$index",
+                  "name": "$even",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11124,10 +11124,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$index",
+                  "value": "$even",
                   "valueSpan": undefined,
                 },
-                "$last": Variable {
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11176,7 +11176,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$last",
+                  "name": "$odd",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11225,10 +11225,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$last",
+                  "value": "$odd",
                   "valueSpan": undefined,
                 },
-                "$odd": Variable {
+                Variable {
                   "keySpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11277,7 +11277,7 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "name": "$odd",
+                  "name": "$count",
                   "sourceSpan": ParseSourceSpan {
                     "details": null,
                     "end": ParseLocation {
@@ -11326,10 +11326,10 @@ describe('parseForESLint()', () => {
                       "offset": 48,
                     },
                   },
-                  "value": "$odd",
+                  "value": "$count",
                   "valueSpan": undefined,
                 },
-              },
+              ],
               "empty": ForLoopBlockEmpty {
                 "children": Array [
                   Text$3 {