Merge branch 'main' into main

angular-eslint · May 21, 2024 · 2b0b762 · 2b0b762
2 parents 9ccafd5 + 4de165d
commit 2b0b762
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -51,6 +51,7 @@ jobs:
         run: |
           yarn --ignore-engines --frozen-lockfile --prefer-offline --ignore-scripts
           yarn check-clean-workspace-after-install
+          npx jest --clearCache
 
       - name: Run parallel distributed tasks for build, typecheck, check-rule-docs, check-rule-lists, lint and test targets
         uses: jameshenry/parallel-bash-commands@v1

diff --git a/.nx/workflows/agents.yaml b/.nx/workflows/agents.yaml
@@ -17,3 +17,5 @@ launch-templates:
         uses: 'nrwl/nx-cloud-workflows/main/workflow-steps/install-node-modules/main.yaml'
         env:
           SKIP_POSTINSTALL: 'true'
+      - name: Clear Jest Cache
+        script: 'npx jest --clearCache'
diff --git a/packages/eslint-plugin/docs/rules/no-input-rename.md b/packages/eslint-plugin/docs/rules/no-input-rename.md
@@ -1141,6 +1141,37 @@ class Test {
 }
 ```
 
+<br>
+
+---
+
+<br>
+
+#### Default Config
+
+```json
+{
+  "rules": {
+    "@angular-eslint/no-input-rename": [
+      "error"
+    ]
+  }
+}
+```
+
+<br>
+
+#### ✅ Valid Code
+
+```ts
+@Component({
+  selector: 'foo'
+})
+class Test {
+  @Input({ transform: (val) => val ?? '', required: true }) foo!: string;
+}
+```
+
 </details>
 
 <br>
diff --git a/packages/eslint-plugin/src/rules/no-input-rename.ts b/packages/eslint-plugin/src/rules/no-input-rename.ts
@@ -110,6 +110,30 @@ export default createESLintRule<Options, MessageIds>({
           return;
         }
 
+        const inputCallExpression = ASTUtils.getNearestNodeFrom(
+          node,
+          ASTUtils.isCallExpression,
+        );
+
+        if (
+          inputCallExpression &&
+          TSESLintASTUtils.isIdentifier(inputCallExpression.callee) &&
+          inputCallExpression.callee.name === 'Input' &&
+          ASTUtils.isObjectExpression(inputCallExpression.arguments?.[0])
+        ) {
+          const [firstArg] = inputCallExpression.arguments;
+
+          const aliasProperty = firstArg.properties.find(
+            (property) =>
+              ASTUtils.isProperty(property) &&
+              ASTUtils.getRawText(property.key) === 'alias',
+          );
+
+          if (!aliasProperty) {
+            return;
+          }
+        }
+
         if (aliasName === propertyName) {
           context.report({
             node,

diff --git a/packages/eslint-plugin/tests/rules/no-input-rename/cases.ts b/packages/eslint-plugin/tests/rules/no-input-rename/cases.ts
@@ -206,6 +206,14 @@ export const valid = [
       @Input({ required: true }) name: string;
     }
   `,
+  `
+    @Component({
+      selector: 'foo'
+    })
+    class Test {
+      @Input({ transform: (val) => val ?? '', required: true }) foo!: string;
+    }
+  `,
 ];
 
 export const invalid = [