fix(eslint-plugin-template): [prefer-self-closing-tags] consider ng-content and ng-template elements

[json-derulo]

Currently the prefer-self-closing-tags rule doesn't report errors on empty <ng-content></ng-content> and <ng-template></ng-template> elements, which is fixed by this pull request.

Closes #1567

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2c2a4c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 7 targets

• nx run-many --target=integration-test --all --withRegistry
• nx run-many -t test --codeCoverage
• nx run-many -t typecheck
• nx run-many -t test
• nx run-many -t build
• nx run-many -t check-rule-docs
• nx run-many -t check-rule-lists

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #1573 (2c2a4c5) into main (59b3204) will increase coverage by 0.01%.
The diff coverage is 95.45%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   89.55%   89.57%   +0.01%     
==========================================
  Files         166      166              
  Lines        3113     3127      +14     
  Branches      526      530       +4     
==========================================
+ Hits         2788     2801      +13     
  Misses        195      195              
- Partials      130      131       +1     

Flag	Coverage Δ
unittest	89.57% <95.45%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...late/tests/rules/prefer-self-closing-tags/cases.ts	100.00% <ø> (ø)
...gin-template/src/rules/prefer-self-closing-tags.ts	97.29% <95.45%> (-2.71%)	⬇️

[JamesHenry]

That's because this didn't used to be supported in Angular:

I don't know when they stopped throwing the above parse error for these but happy to learn that they did.

[JamesHenry]

Thanks @json-derulo I've added this to the v17 branch just in case this change in behaviour is particularly disruptive for larger codebases

[JamesHenry]

@json-derulo I'm afraid I've had to revert for the two plugins, it causes compilation issues with typescript-eslint v6

[json-derulo]

@JamesHenry Could you explain in more detail what the problem with typescript-eslint v6 is? I checked out the next-major-release/v17 branch (which still includes my commit) and after installing the dependencies, I ran lint, test & build. Everything seems to work fine for me.

[JamesHenry]

It includes your commit but then the aforementioned revert to the plugins by me: 2498238

The issue is typescript-eslint/typescript-eslint#7605