feat(eslint-plugin): [use-injectable-provided-in] add suggestion #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Jul 12, 2021
| { | ||
| type: 'object', | ||
| properties: { | ||
| ignoreClassNamePattern: { |
There was a problem hiding this comment.
Not really sure about this name.
Nx Cloud ReportCI ran the following commands for commit d8ba868. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
rafaelss95
force-pushed
the
feat/use-injectable-provided-in
branch
2 times, most recently
from
4b7380f
to
27891f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 86.05% 86.03% -0.02%
==========================================
Files 89 89
Lines 2402 2421 +19
Branches 416 421 +5
==========================================
+ Hits 2067 2083 +16
- Misses 200 201 +1
- Partials 135 137 +2
|
rafaelss95
force-pushed
the
feat/use-injectable-provided-in
branch
from
27891f9
to
6bbc8a1
Compare
rafaelss95
force-pushed
the
feat/use-injectable-provided-in
branch
4 times, most recently
from
7afac2c
to
6f14473
Compare
JamesHenry
requested changes
Aug 27, 2021
…implements `HttpInterceptor`
…e classes given a pattern
rafaelss95
force-pushed
the
feat/use-injectable-provided-in
branch
from
6f14473
to
d421e22
Compare
|
Thanks @rafaelss95! |
This was referenced Oct 1, 2021
build(deps-dev): bump @angular-eslint/builder from 12.3.1 to 12.5.0
numbersprotocol/capture-lite#941
Closed
|
@rafaelss95 Hiii, my I ask a question. why the null value is wrong? Isn't it a default value? Like official comment says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st. commit: adds suggestions that covers the most common values and also fixes some false negatives like when we use
nullas value or when we use a computed argument to@Injectabledecorator and false positives when we use'providedIn'as aLiteral;2nd. commit: ignore classes that implements
HttpInterceptor(see #236);3rd. commit: add option to ignore classes given a pattern (see #236).
Closes #236.