Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package group for ng update #807

Merged
merged 1 commit into from Nov 18, 2021
Merged

feat: add package group for ng update #807

merged 1 commit into from Nov 18, 2021

Conversation

kyubisation
Copy link
Contributor

ng update checks the "ng-update"."packageGroup" field in the package.json for related packages. If defined these will also be updated to the resolved version: https://github.com/angular/angular-cli/blob/master/docs/specifications/update.md#library-developers
This simplifies the update procedure; Consumers will only have to execute ng update @angular-eslint/schematics, which will update all installed @angular-eslint/* packages.

`ng update` checks the "ng-update"."packageGroup" field in the package.json for related packages. If defined these will also be updated to the resolved version: https://github.com/angular/angular-cli/blob/master/docs/specifications/update.md#library-developers
This simplifies the update procedure; Consumers will only have to execute `ng update @angular-eslint/schematics`, which will update all installed `@angular-eslint/*` packages.
@nx-cloud
Copy link

nx-cloud bot commented Nov 17, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 0e8cfbe.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already applied this in the v13 branch which is in prerelease, but we can go ahead and merge this as I am going to publish another 12 minor first

@JamesHenry JamesHenry merged commit ce2e47d into angular-eslint:master Nov 18, 2021
@kyubisation kyubisation deleted the patch-1 branch November 18, 2021 13:56
@kyubisation
Copy link
Contributor Author

Sorry, I hadn't noticed that. Thank you anyway for the merge. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants