-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-template): [button-has-type] add rule #928
feat(eslint-plugin-template): [button-has-type] add rule #928
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd5386e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 9 targets
Sent with 💌 from NxCloud. |
Hi @JamesHenry, I'd appreciate if you could look into this PR. So that we could continue working on it or, at least, close it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry for the delay in getting back to you on this @chernodub and thank you so much for taking the initiative and contributing this rule.
Please take a look at the review comments. You will also need to run yarn update-rule-docs
in order to generate the necessary rule documentation to accompany this rule.
packages/eslint-plugin-template/tests/rules/button-has-type/cases.ts
Outdated
Show resolved
Hide resolved
f095b34
to
cd5386e
Compare
Thanks a lot for a valuable feedback @JamesHenry! 🙏 I've updated the code following your comments (agreed to all the points you mentioned). I've also rebased the changes on |
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 87.20% 87.35% +0.15%
==========================================
Files 147 149 +2
Lines 2782 2815 +33
Branches 450 454 +4
==========================================
+ Hits 2426 2459 +33
Misses 252 252
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks a lot @chernodub! I'll release this on v13 so you're not forced to upgrade to v14 of Angular to use it |
closes #823