feat(eslint-plugin-template): [button-has-type] add rule

[chernodub]

closes #823

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cd5386e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 9 targets

• Node v16.15.1 - nx run-many --target=integration-test --all --withRegistry
• Node v16.15.1 - nx run-many --target=test --all --parallel --codeCoverage
• Node v12.22.12 - nx run-many --target=test --all --parallel
• Node v16.15.1 - nx run-many --target=typecheck --all --parallel
• Node v16.15.1 - nx run-many --target=build --all --parallel
• Node v12.22.12 - nx run-many --target=build --all --parallel
• Node v14.19.3 - nx run-many --target=test --all --parallel
• Node v16.15.1 - nx run-many --target=check-rule-docs --all --parallel
• Node v14.19.3 - nx run-many --target=build --all --parallel

---

Sent with 💌 from NxCloud.

[chernodub]

Hi @JamesHenry, I'd appreciate if you could look into this PR. So that we could continue working on it or, at least, close it. Thanks!

[JamesHenry]

I'm very sorry for the delay in getting back to you on this @chernodub and thank you so much for taking the initiative and contributing this rule.

Please take a look at the review comments. You will also need to run yarn update-rule-docs in order to generate the necessary rule documentation to accompany this rule.

[chernodub]

Thanks a lot for a valuable feedback @JamesHenry! 🙏

I've updated the code following your comments (agreed to all the points you mentioned). I've also rebased the changes on origin/master branch, so it's ready for merging.

[codecov]

Codecov Report

Merging #928 (cd5386e) into master (0bda2bb) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   87.20%   87.35%   +0.15%     
==========================================
  Files         147      149       +2     
  Lines        2782     2815      +33     
  Branches      450      454       +4     
==========================================
+ Hits         2426     2459      +33     
  Misses        252      252              
  Partials      104      104              

Flag	Coverage Δ
unittest	87.35% <100.00%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin-template/src/index.ts	66.66% <ø> (+0.70%)	⬆️
...slint-plugin-template/src/rules/button-has-type.ts	100.00% <100.00%> (ø)
...ugin-template/tests/rules/button-has-type/cases.ts	100.00% <100.00%> (ø)

[JamesHenry]

Thanks a lot @chernodub! I'll release this on v13 so you're not forced to upgrade to v14 of Angular to use it