Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [attributes-order] fixes for structural … #1602

Merged

Conversation

pmccloghrylaing
Copy link
Contributor

…directives and i18n ordering

Fixes #1500, #1519

Copy link

nx-cloud bot commented Nov 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0cf8f48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

} else {
while (!/[\s>]/.test(keyEnd.getContext(0, 0)?.after ?? '')) {
keyEnd = keyEnd.moveBy(1);
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of trying to merge multiple spans it works out the value span separately. This deals with contained template variables and extra whitespace within the value.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1602 (0cf8f48) into main (d4c1eaa) will decrease coverage by 0.28%.
Report is 27 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 0cf8f48 differs from pull request most recent head cfced6a. Consider uploading reports for the commit cfced6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
- Coverage   89.55%   89.28%   -0.28%     
==========================================
  Files         166      167       +1     
  Lines        3113     3145      +32     
  Branches      526      538      +12     
==========================================
+ Hits         2788     2808      +20     
- Misses        195      199       +4     
- Partials      130      138       +8     
Flag Coverage Δ
unittest 89.28% <100.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lint-plugin-template/src/rules/attributes-order.ts 88.39% <100.00%> (-8.61%) ⬇️
...gin-template/tests/rules/attributes-order/cases.ts 100.00% <ø> (ø)

... and 47 files with indirect coverage changes

@abaran30
Copy link
Contributor

abaran30 commented Nov 9, 2023

FYI @skrtheboss

…ases.ts

Co-authored-by: Adrian Baran <93612066+abaran30@users.noreply.github.com>
@JamesHenry JamesHenry merged commit 9506c98 into angular-eslint:main Nov 15, 2023
1 check passed
@JamesHenry
Copy link
Member

Thank you both!

@abaran30
Copy link
Contributor

abaran30 commented Apr 4, 2024

FYI, reopened #1519; see comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[attributes-order] auto-fix results in invalid HTML
3 participants