-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin-template): [attributes-order] fixes for structural … #1602
fix(eslint-plugin-template): [attributes-order] fixes for structural … #1602
Conversation
…directives and i18n ordering Fixes angular-eslint#1500, angular-eslint#1519
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0cf8f48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
} else { | ||
while (!/[\s>]/.test(keyEnd.getContext(0, 0)?.after ?? '')) { | ||
keyEnd = keyEnd.moveBy(1); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of trying to merge multiple spans it works out the value span separately. This deals with contained template variables and extra whitespace within the value.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
- Coverage 89.55% 89.28% -0.28%
==========================================
Files 166 167 +1
Lines 3113 3145 +32
Branches 526 538 +12
==========================================
+ Hits 2788 2808 +20
- Misses 195 199 +4
- Partials 130 138 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FYI @skrtheboss |
packages/eslint-plugin-template/tests/rules/attributes-order/cases.ts
Outdated
Show resolved
Hide resolved
…ases.ts Co-authored-by: Adrian Baran <93612066+abaran30@users.noreply.github.com>
Thank you both! |
FYI, reopened #1519; see comment there. |
…directives and i18n ordering
Fixes #1500, #1519