Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix max inline declarations rule for styles string #1630

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

csvn
Copy link
Contributor

@csvn csvn commented Nov 20, 2023

This fix is for component-max-inline-declarations rule to also apply for styles with a string:

@Component({
  styles: `
    :host { display: block; }
  `
})
class Foo {}

Copy link

nx-cloud bot commented Nov 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5e1968f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1630 (5e1968f) into main (b489924) will increase coverage by 0.06%.
Report is 17 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
+ Coverage   89.38%   89.44%   +0.06%     
==========================================
  Files         169      169              
  Lines        3174     3174              
  Branches      540      540              
==========================================
+ Hits         2837     2839       +2     
+ Misses        199      198       -1     
+ Partials      138      137       -1     
Flag Coverage Δ
unittest 89.44% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gin/src/rules/component-max-inline-declarations.ts 82.85% <100.00%> (+5.71%) ⬆️
...s/rules/component-max-inline-declarations/cases.ts 100.00% <ø> (ø)

@JamesHenry JamesHenry merged commit 1ab25ba into angular-eslint:main Nov 30, 2023
14 checks passed
@JamesHenry
Copy link
Member

Thank you @csvn!

@csvn csvn deleted the fix/max-inline-v17-fix branch November 30, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants