fix(eslint-plugin-template): [eqeqeq] Calculate offset to find true absolute source span #1709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1666
Problem:
In angular's parser, leading whitespace or newline is ignored when calculating AbsoluteSourceSpan. 12
Solution:
This PR finds the true AbsoluteSourceSpan by calculating the leading trivia characters offset.
Assistance requested:
Not sure how to add a leading newline (e.g. code snippet in #1666) in
annotatedSource
without causing issues inannotatedOutput
.Reference
Footnotes
https://github.com/angular/angular/blob/main/packages/compiler/src/ml_parser/lexer.ts#L87 ↩
https://hackmd.io/@X3ECPVy-RCuVfba-pnvIpw/BkDUxaW84/%2FMA1oxh6jRXqSmZBcLfYdyw?type=book)%5C#Parser ↩