-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin-template): [label-has-associated-control] check id's in the for attribute of a label for existence #1761
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd95e0b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @air2, please run yarn update-rule-docs
and commit the result
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
=======================================
Coverage 90.46% 90.47%
=======================================
Files 178 178
Lines 3345 3359 +14
Branches 536 540 +4
=======================================
+ Hits 3026 3039 +13
Misses 185 185
- Partials 134 135 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@JamesHenry Sorry I had some other projects lately, so I had not time to get back at this, before now, I see it is already, merged, thank you! And sorry for my late reply and not picking your request up sooner |
This should fix issue #1759