-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-template): [i18n] add allowMarkupInContent option #1795
Conversation
@JamesHenry There haven't been any comments or review since I put this up a couple weeks ago. Just wanted to ping someone to make sure it isn't overlooked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @m-akinc!
I would prefer it if no existing tests were modified by this PR to prove that this change is backwards compatible. Please can you make the necessary updates?
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7db729b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 90.47% 90.43% -0.04%
==========================================
Files 178 178
Lines 3361 3368 +7
Branches 540 542 +2
==========================================
+ Hits 3041 3046 +5
- Misses 185 186 +1
- Partials 135 136 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you @m-akinc! |
Fixes #930
Added
allowMarkupInContent
option fori18n
rule. Option defaults totrue
to maintain backwards compatibility. Setting tofalse
causes rule violation whenever an element with thei18n
attribute has HTML markup in its content.Note that due to the way the AST parser handles ICUs (i.e. it escapes any markup in cases so that they are strings), we cannot report violations for markup inside the ICU cases.