-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin-template): [prefer-self-closing-tags] always ignore index.html files #1865
fix(eslint-plugin-template): [prefer-self-closing-tags] always ignore index.html files #1865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to add a unit test for this by setting filename
please
added! |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ec2155. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Test looks good, please run |
i've updated the docs. However currently the result doesn't make sense in this context. Is there a ways to simply annotate a rule output? e.g. I could add a simple comment input to the markdown converter, but not sure what would be wanted here. |
Ah yeah good spot, let's please extend the rules doc generation logic to print the filename above the code snippet in the case that it is explicitly set in the unit test, e.g. the result would look like the below: Filename: src/index.html <app-root></app-root> |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
=======================================
Coverage 91.62% 91.63%
=======================================
Files 179 179
Lines 3380 3382 +2
Branches 547 548 +1
=======================================
+ Hits 3097 3099 +2
Misses 144 144
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks so much @Squixx! |
Thanks for guiding me through the repo. |
@JamesHenry Is there a plan on getting this fix released anytime soon? |
Ignores index.html files for prefer-self-closing-tags as described in #1857