Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-action): skip publish on forks #1873

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Jun 8, 2024

Improvement

Skip publish workflow on forked repositories

Currently

Publish workflow is executed on forks:

https://github.com/chimurai/angular-eslint/actions/runs/9324614358

image

Copy link

nx-cloud bot commented Jun 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e609a16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@chimurai chimurai changed the title ci(github-action): skip publish workflow on forks ci(github-action): skip publish on forks Jun 8, 2024
@chimurai chimurai closed this Jun 8, 2024
@chimurai chimurai deleted the skip-publish-in-forks branch June 8, 2024 11:37
@JamesHenry
Copy link
Member

@chimurai How come you closed this? It seems like a good idea to me

@chimurai
Copy link
Contributor Author

chimurai commented Jun 9, 2024

Bumped into some errors after opening the PR.

Can reopen the PR and work on the errors 👍

@JamesHenry
Copy link
Member

@chimurai it was just some flakiness, sorry about that, yes please reopen and I’ll make sure it gets merged

@chimurai chimurai restored the skip-publish-in-forks branch June 9, 2024 20:05
@chimurai chimurai reopened this Jun 9, 2024
@JamesHenry JamesHenry merged commit 2f9e378 into angular-eslint:main Jun 9, 2024
11 of 12 checks passed
@JamesHenry
Copy link
Member

Thanks!

@chimurai
Copy link
Contributor Author

Thanks for accepting the PR.

Can confirm publish is skipped in forks:
https://github.com/chimurai/angular-eslint/actions/runs/9453647261

image

@chimurai chimurai deleted the skip-publish-in-forks branch June 10, 2024 18:37
@JamesHenry
Copy link
Member

Excellent, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants