-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prefer-output-readonly] support output() function #1876
feat(eslint-plugin): [prefer-output-readonly] support output() function #1876
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8663376. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
=======================================
Coverage 91.62% 91.63%
=======================================
Files 179 179
Lines 3380 3383 +3
Branches 547 547
=======================================
+ Hits 3097 3100 +3
Misses 144 144
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please add support for OutputRef from function outputFromObservable |
That should already be handled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @reduckted!
Fixes #1871
The
prefer-output-readonly
rule will now report a problem for any class property that does not have the readonly modifier and has either a type annotation ofOutputEmitterRef<T>
, or is assigned the result of theoutput()
function.