-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-template): accessibility-alt-text #227
feat(eslint-plugin-template): accessibility-alt-text #227
Conversation
messageId, | ||
description: 'should fail image does not have alt text', | ||
annotatedSource: ` | ||
<img src="foo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey James. I've got a question. The end source span is not set for void elements. What is the proper way to get the location of this node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d be curious if it was there if you added the / in front of the > denoting it is the closing tag of a void element...
In any case though questions about the AST the angular compiler produces for us kind of have to be posted on their repo. Most things I know about it have just been inferred by fiddling with and logging the output of things, and fortunately that’s been enough most of the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a feature to get the location of void elements. Could you have a look, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, this seems reasonable to me!
No description provided.