fix(eslint-plugin-template): handle 'innerHtml' input properly #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
commented
Dec 20, 2020
| @@ -21,7 +21,7 @@ ruleTester.run(RULE_NAME, rule, { | |||
| valid: [ | |||
| '<h1>Heading Content!</h1>', | |||
| '<h2><app-content></app-content></h2>', | |||
| '<h3 [innerHTML]="dangerouslySetHTML"></h3>', | |||
| '<h3 [innerHtml]="dangerouslySetHTML"></h3>', | |||
There was a problem hiding this comment.
Btw, there's already a test case on line 28 that test the innerHTML:
rafaelss95
force-pushed
the
fix/accessibility-elements-content
branch
from
3bc9307
to
62d7275
Compare
rafaelss95
force-pushed
the
fix/accessibility-elements-content
branch
from
62d7275
to
9440c42
Compare
|
I need to report this flakiness to verdaccio, it's so frequent on the integrations test job, particular on master... |
|
Reported it to verdaccio: verdaccio/verdaccio#2038 |
rafaelss95
added a commit
to rafaelss95/angular-eslint
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
We can pass html content by using
innerHTMLandinnerHtml. The later isn't currently ignored by the rule.Expected behavior:
I also replaced conditionals by selectors to make it more readable and shorter.