Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v3.0.0 #388

Merged
merged 18 commits into from Apr 17, 2021
Merged

feat: v3.0.0 #388

merged 18 commits into from Apr 17, 2021

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Mar 29, 2021

BREAKING CHANGE

This release branch will collect up all the breaking changes we want to merge for v2. We will also publish prereleases to npm from this branch.

Fixes #383, fixes #348, fixes #322, fixes #321, fixes #401

@JamesHenry JamesHenry added the BREAKING CHANGE This is a breaking change and should only be released as part of a new major version label Mar 29, 2021
@JamesHenry JamesHenry added this to the v3 milestone Mar 29, 2021
@JamesHenry JamesHenry self-assigned this Mar 29, 2021
@nx-cloud
Copy link

nx-cloud bot commented Mar 29, 2021

Nx Cloud Report

CI ran the following commands for commit 3582e8e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #388 (3582e8e) into master (bcefb9f) will increase coverage by 5.27%.
The diff coverage is 86.11%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   63.88%   69.15%   +5.27%     
==========================================
  Files          12       13       +1     
  Lines         443      509      +66     
  Branches       74       92      +18     
==========================================
+ Hits          283      352      +69     
+ Misses        132      119      -13     
- Partials       28       38      +10     
Impacted Files Coverage Δ
...nvert-tslint-to-eslint/convert-to-eslint-config.ts 56.25% <ø> (ø)
...s/schematics/src/convert-tslint-to-eslint/index.ts 50.94% <ø> (ø)
packages/builder/src/utils/eslint-utils.ts 76.92% <66.66%> (-4.90%) ⬇️
...matics/src/migrations/update-3-0-0/update-3-0-0.ts 86.36% <86.36%> (ø)
...matics/src/migrations/update-2-0-0/update-2-0-0.ts 92.10% <100.00%> (ø)
packages/schematics/src/ng-add/index.ts 82.75% <100.00%> (-1.12%) ⬇️
...s/schematics/src/convert-tslint-to-eslint/utils.ts 81.39% <0.00%> (+30.23%) ⬆️

@JamesHenry JamesHenry marked this pull request as ready for review April 17, 2021 13:13
@JamesHenry JamesHenry merged commit f92b184 into master Apr 17, 2021
@JamesHenry JamesHenry deleted the next-major-release/v3 branch April 17, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment