Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): properly handle computed literals for some rules #600

Merged

Conversation

rafaelss95
Copy link
Member

With this, computed literals are now reported in the following rules:

  • no-inputs-metadata-property;
  • no-input-prefix;
  • no-input-rename;
  • no-pipe-impure;
  • use-view-encapsulation.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #600 (e492c5c) into master (997991c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          89       89           
  Lines        2402     2402           
  Branches      416      416           
=======================================
  Hits         2067     2067           
  Misses        200      200           
  Partials      135      135           
Impacted Files Coverage Δ
...nt-plugin/src/rules/no-inputs-metadata-property.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-pipe-impure.ts 100.00% <100.00%> (ø)
...ugin/src/rules/use-component-view-encapsulation.ts 92.30% <100.00%> (ø)

@nx-cloud
Copy link

nx-cloud bot commented Jul 16, 2021

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the conflicts from when the doc generation work went in

@JamesHenry JamesHenry enabled auto-merge (squash) August 31, 2021 09:23
@JamesHenry JamesHenry merged commit fbd6ff7 into angular-eslint:master Aug 31, 2021
@rafaelss95 rafaelss95 deleted the fix/inputs-computed-literals branch August 31, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants