New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): properly handle computed literals for some rules #600
fix(eslint-plugin): properly handle computed literals for some rules #600
Conversation
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 89 89
Lines 2402 2402
Branches 416 416
=======================================
Hits 2067 2067
Misses 200 200
Partials 135 135
|
Nx Cloud ReportCI ran the following commands for commit e492c5c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
Nx Cloud ReportCI ran the following commands for commit 8eeb068. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the conflicts from when the doc generation work went in
8eeb068
to
1c111c1
Compare
With this, computed literals are now reported in the following rules:
no-inputs-metadata-property
;no-input-prefix
;no-input-rename
;no-pipe-impure
;use-view-encapsulation
.