Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: create own bundle for @angular/compiler #720

Merged

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 25, 2021

With this change we create a a package to bundle @angular/compiler. This is in preparation for version 13 were the angular packages are only shipped in ESM format however due to limitations in ESLint these cannot be consumed directly. Therefore, we have created a "private" @angular-eslint/bundled-angular-compiler package which contains the a CJS bundled version of the @angular/compiler. All references to @angular/compiler in the code base have been changed to reference this change.

With this change we create a a package to bundle `@angular/compiler`. This is in preparation for version 13 were the angular packages are only shipped in ESM format however due to limitations in ESLint these cannot be consumed directly. Therefore, we have created a "private" `@angular-eslint/bundled-angular-compiler` package which contains the a CJS bundled version of the `@angular/compiler`.  All references to `@angular/compiler` in the code base have been changed to reference this change.
Builders don't require a dependency on the `@angular/cli` to be executed.
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #720 (c40eaa2) into master (8ac2193) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          83       83           
  Lines        1922     1922           
  Branches      339      339           
=======================================
  Hits         1641     1641           
  Misses        170      170           
  Partials      111      111           
Impacted Files Coverage Δ
...mplate/src/rules/accessibility-elements-content.ts 100.00% <ø> (ø)
...ugin-template/src/rules/accessibility-label-for.ts 88.46% <ø> (ø)
...ules/accessibility-label-has-associated-control.ts 82.14% <ø> (ø)
.../eslint-plugin-template/src/rules/banana-in-box.ts 100.00% <ø> (ø)
...template/src/rules/click-events-have-key-events.ts 100.00% <ø> (ø)
...template/src/rules/mouse-events-have-key-events.ts 100.00% <ø> (ø)
...ackages/eslint-plugin-template/src/rules/no-any.ts 100.00% <ø> (ø)
...ugin-template/src/rules/no-distracting-elements.ts 100.00% <ø> (ø)
...plugin-template/src/utils/attributes-comparator.ts 90.90% <ø> (ø)
...t-plugin-template/src/utils/get-attribute-value.ts 60.00% <ø> (ø)
... and 27 more

@JamesHenry JamesHenry merged commit 0c42299 into angular-eslint:master Oct 25, 2021
@alan-agius4 alan-agius4 deleted the bundle-angular-compiler- branch October 25, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants