New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: create own bundle for @angular/compiler
#720
Merged
JamesHenry
merged 4 commits into
angular-eslint:master
from
alan-agius4:bundle-angular-compiler-
Oct 25, 2021
Merged
build: create own bundle for @angular/compiler
#720
JamesHenry
merged 4 commits into
angular-eslint:master
from
alan-agius4:bundle-angular-compiler-
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit c40eaa2. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
With this change we create a a package to bundle `@angular/compiler`. This is in preparation for version 13 were the angular packages are only shipped in ESM format however due to limitations in ESLint these cannot be consumed directly. Therefore, we have created a "private" `@angular-eslint/bundled-angular-compiler` package which contains the a CJS bundled version of the `@angular/compiler`. All references to `@angular/compiler` in the code base have been changed to reference this change.
Builders don't require a dependency on the `@angular/cli` to be executed.
alan-agius4
force-pushed
the
bundle-angular-compiler-
branch
from
October 25, 2021 09:02
78e8083
to
6f392a8
Compare
alan-agius4
force-pushed
the
bundle-angular-compiler-
branch
from
October 25, 2021 09:47
9122737
to
c40eaa2
Compare
This was referenced Nov 1, 2021
This was referenced Dec 1, 2021
This was referenced Mar 1, 2022
This was referenced May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we create a a package to bundle
@angular/compiler
. This is in preparation for version 13 were the angular packages are only shipped in ESM format however due to limitations in ESLint these cannot be consumed directly. Therefore, we have created a "private"@angular-eslint/bundled-angular-compiler
package which contains the a CJS bundled version of the@angular/compiler
. All references to@angular/compiler
in the code base have been changed to reference this change.