feat(rule): do not check for the complete method to be called since i…

…ts not necessary (#3)
angular-extensions · Mar 12, 2020 · d661791 · d661791
1 parent a7f7d99
commit d661791
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/rules/angularRxjsTakeuntilBeforeSubscribeRule.ts b/rules/angularRxjsTakeuntilBeforeSubscribeRule.ts
@@ -415,7 +415,7 @@ export class Rule extends Lint.Rules.TypedRule {
   }
 
   /**
-   * Checks whether the class implements an ngOnDestroy method and invokes .next() and .complete() on the destroy subjects
+   * Checks whether the class implements an ngOnDestroy method and invokes .next() on the destroy subjects
    */
   private checkNgOnDestroy(
     sourceFile: ts.SourceFile,
@@ -428,7 +428,7 @@ export class Rule extends Lint.Rules.TypedRule {
     );
 
     // check whether the ngOnDestroy method is implemented
-    // and contains invocations of .next() and .complete() on all destroy subjects used
+    // and contains invocations of .next() on all destroy subjects used
     if (ngOnDestroyMethod) {
       failures.push(
         ...this.checkDestroySubjectMethodInvocation(
@@ -438,14 +438,6 @@ export class Rule extends Lint.Rules.TypedRule {
           "next"
         )
       );
-      failures.push(
-        ...this.checkDestroySubjectMethodInvocation(
-          sourceFile,
-          ngOnDestroyMethod,
-            destroySubjectNameUsed,
-          "complete"
-        )
-      );
     } else {
       failures.push(
         new Lint.RuleFailure(

diff --git a/test/rules/angular-rxjs-takeuntil-before-subscribe/component/fixture.ts.lint b/test/rules/angular-rxjs-takeuntil-before-subscribe/component/fixture.ts.lint
@@ -78,10 +78,8 @@ class MyComponent implements OnDestroy {
 
     ngOnDestroy() {
     ~~~~~~~~~~~            [angular-rxjs-takeuntil-before-subscribe-subscribe-next-missing]
-    ~~~~~~~~~~~            [angular-rxjs-takeuntil-before-subscribe-subscribe-complete-missing]
       // this._destroy$.next() is missing
       this.destroy$.next();
-      this.destroy$.complete();
     }
 }
 
@@ -126,7 +124,6 @@ class MyComponent implements SomeInterface, OnDestroy {
 
     ngOnDestroy() {
       this.destroy$.next();
-      this.destroy$.complete();
     }
 }
 
@@ -140,7 +137,6 @@ class MySuperAbstractComponent2 {
 
     ngOnDestroy() {
       this.destroy$.next();
-      this.destroy$.complete();
     }
 }
 

diff --git a/test/rules/angular-rxjs-takeuntil-before-subscribe/directive/fixture.ts.lint b/test/rules/angular-rxjs-takeuntil-before-subscribe/directive/fixture.ts.lint
@@ -73,7 +73,6 @@ class MyDirective implements OnDestroy {
 
     ngOnDestroy() {
     ~~~~~~~~~~~            [angular-rxjs-takeuntil-before-subscribe-subscribe-next-missing]
-    ~~~~~~~~~~~            [angular-rxjs-takeuntil-before-subscribe-subscribe-complete-missing]
       // this._destroy$.next() is missing
       this.destroy$.next();
       this.destroy$.complete();